- Mar 04, 2025
-
-
Steve Lhomme authored
It's always the same as the p_picture one.
-
Steve Lhomme authored
We don't need the full subpicture_region_t for that.
-
Steve Lhomme authored
No need to go through an intermediate p_reg.
-
-
-
-
-
-
-
-
-
fixes artist loading with large medialibrary
-
-
macosx: When set as a main menu's instance, update the presented item on stat target change in info window Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Fixes multiple bugs with view value changes not being reflected as expected Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by:
Claudio Cambra <developer@claudiocambra.com>
-
-
-
-
- Mar 03, 2025
-
-
- Mar 02, 2025
-
-
`QWindow`'s `wl_surface` gets deleted when `QWindow::hide()` is called. This is an exceptional behavior, and can be considered a bug because destroying the window resources is tied to `QWindow::destroy()`, calling `QWindow::hide()` should not destroy the window's resources.
-
libtool doesn't handle frameworks as dependencies, and only support them as linker argument (ie. -Wl,-framework arguments). Remove them from the link to prevent the linkage failure. This also means that they must be provided manually in the makefile afterwards...
-
- Mar 01, 2025
-
-
Steve Lhomme authored
No need to set it on each iteration.
-
Steve Lhomme authored
realloc works fine on NULL. The pointer is set in p_subtitle->psz_text which is free'd later. It's OK to free a NULL pointer if there wasn't any line to use.
-
Steve Lhomme authored
No need to do a lengthy strlen() call each time the concatenated string grows.
-
Steve Lhomme authored
We're just concatenating the lines in psz_text.
-
Steve Lhomme authored
-
Steve Lhomme authored
We already use flags to fill some arrays like AOUT_MIX_MODE_xxx or VOUT_ALIGN_xxx. The downside is that we cannot change the defines without breaking the libvlc API. But SUBPICTURE_ALIGN_xxx defines are also used by many module as source for parameters, so these would break as well.
-
Steve Lhomme authored
It's clearer when it's not weird.
-
- `GetSystemMetrics()` function already scales most of the metrics for the primary monitor [1], evidently because Qt makes the application DPI aware. - Currently by multiplying the `GetSystemMetrics()` result with `windowDpi / screenDpi`, we apply the window's DPI which is what is wanted here. - If the window is in the primary monitor, there is no problem. If there are multiple monitors but they share the same DPI, there should also be no problem. But if there are multiple monitors that have different DPIs, in that case dragging would be problematic. - The solution that Windows recommends [2] is using `GetSystemMetricsForDpi` and `GetDpiForWindow`. Unfortunately these are only available on Windows 10, so I dynamically load the necessary library and resolve the symbols. - Handling `WM_DPICHANGED` and calling `SetWindowPos()` should not be necessary, because Qt already calls it to resize the window according to the new dpi. [1] https://learn.microsoft.com/en-us/windows/win32/gdi/multiple-monitor-system-metrics [2] https://learn.microsoft.com/en-us/windows/win32/hidpi/high-dpi-desktop-application-development-on-windows#updating-existing-applications
-
-
-
If the display is opened on a window that is not matching with a DirectComposition backend or HWND backend, the module should not even try to open.
-
The decoder fifo level metric allows interpreting the situation that led to the fifo from the decoder to be flushed (ie. the fifo reached 400MiB of undecoded data stored). The metrics generates a lot of points though, so be sure to aggregate when displaying it. Example of query in flux language: from(bucket: v.defaultBucket) |> range(start: v.timeRangeStart, stop:v.timeRangeStop) |> filter(fn: (r) => r._measurement == "measurement" and r._field == "fifo_size" ) |> aggregateWindow(every: 1s, fn: max) The size metrics are casted into uint64_t, but are always below the uint64_t max value anyway given they represent lesser values than 400MiB.
-
-
-
-
Unsigned support allows tracing sizes and counters.
-
Steve Lhomme authored
Now that we can position subpictures outside of the video.
-