Mangal Kushwah authored 9 months ago and Duncan McNamara committed 7 months ago

See: videolan/vlc!5680,
HWDecoderUtil logic is moved in audio_output/android/device.c so it is
not needed.

Steve Lhomme authored 1 year ago and Duncan McNamara committed 7 months ago

sh is not usable on Windows.
Then the command is the same as for the libvlc version.

redefined symbols

Steve Lhomme authored 7 months ago and Duncan McNamara committed 7 months ago

It's called for all targets and doesn't appear to have Android API version checks.

Steve Lhomme authored 7 months ago and Duncan McNamara committed 7 months ago

This should avoid rebuilding ninja.

Steve Lhomme authored 7 months ago and Duncan McNamara committed 7 months ago

No need to make it artificially slower.

The minimum Android version is 17 (Jeally Bean MR1)

The minimum Android version is 17 (Jeally Bean MR1)

The minimum Android version is 17 (Jeally Bean MR1)

The minimum Android version is 17 (Jeally Bean MR1)

That's how a lot of systems build contribs so we are shown
the problematic contrib at the end of the (CI) logs.

They are neither used locally nor in the VLC build system.

It's not necessary.

We only support FFmpeg now.

It should have been fixed in VLC contribs by 903c250978153ef8d95a6005def39ab0ad4078f9.

It results in an error in my system:
Generating libvlc pkg-config file: /mnt/s/sources/libvlcjni/buildsystem/../libvlc/jni/pkgconfig/x86_64//libvlc.pc
./buildsystem/compile-libvlc.sh: 734: en: Permission denied

It's supported by ANDROID_API 28, in the contribs.
Let the contribs decide if it's needed or not.

So we can see what's going on. Other build targets do that too.

protoc is missing so Chromecast is disabled.

bootstrap doesn't (really) take arguments. There are contrib flags.

Just like vlc.

SetObjectArrayElement() is creating its own ref, we need to release our
local one after this call.

sed defaults to BRE, which treats + as a normal character.

LibVLC accept only "%u/%u" as AR.

The updatePlayerLayout boolean was not enough, specially since we know
inside the updateVideoSurfaces() function if we are using OpenGL or
MediaCodec rendering.

This doesn't seem to fix anything but this will trigger less round trip
between VLC and video size callbacks.

Macro magic but much more convenient to add methods and classes
since you only need to add it in one place now (jni_bindings.h).