Ronald S. Bultje authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

The wrapper function already backs up GPRs, and declaring 7 here means
we will backup/restore twice on x86-32.

Mehdi Sabwat authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

When targetting wasm32-unknown-emscripten, we need to have the -pthread option during
compilation for all the objects that use atomic instructions.

When -pthread option is used on a object that has atomic instructions, a section is added
to the binary notifying the linker that it is safe to use shared linear memory because
atomic instructions were not stripped (default behavior if the option is not set).

cf. https://github.com/WebAssembly/tool-conventions/blob/master/Linking.md#target-features-section

Before this patch, lib.c and thread_task.c were using atomic instructions but since -pthread was not
passed during compilation a section was added to the binary, disallowing shared linear memory
and preventing linking dav1d with a multi threaded wasm application.

It also renames stdatomic_dependency to stdatomic_dependencies, for clarity because it is now
an array of dependency objects.

cf. https://mesonbuild.com/Reference-manual.html#dependency-object

James Almer authored 3 years ago and Jean-Baptiste Kempf committed 3 years ago

Helps differentiating actual errors in the buffer data or passed-in arguments
with scenarios like empty buffers or containing OBUs other than Sequence
Header.

Saves one move.

Henrik Gramner authored 3 years ago and Henrik Gramner committed 3 years ago

We use the 'noinline' attribute in order to reduce code size, but that
doesn't prevent gcc from cloning the function, which is something that
goes against the purpose of preventing inlining in the first place.

Adding the 'noclone' attribute reduces the (stripped) binary size by
around 45 kB on x86-64.