- Sep 19, 2024
-
-
It should not change anything since modules don't send timings point just after start (they do it after the first playback), but nothing prevent it in the documentation. This also fixes Reset() not being calling if the start of the module fails (just after the stop).
-
Steve Lhomme authored
This could end up with unknown/invalid error values.
-
Since mingw-w64 20331109d1c90c19a510408ab119a76004bc41ea (September 17th), mingw-w64 headers do provide these GUIDs. (They come from Wine as upstream, from Wine commit 6dfb84f5cbdf30c1dc0775fd4dae821ee8705ad4 from September 10th.) This change does break building with older mingw-w64 13 git snapshots though.
-
Steve Lhomme authored
The assert is only useful to check the values match, not that D3D11_GetSystemDriver() may fail, which happens on Windows ARM. Fixes #28787
-
In some corner cases where the module is flushed more than one times in a raw, it was possible that the renderer and observer were first started during the stop process
-
- Sep 18, 2024
-
-
This fixes npt or length not being updated in time by timer clients since the input source is not likely the best_source.
-
After a seek, the demux module can fail to get the NPT. Don't fallback to TICK_0 in that case, but use the previous value. Fixes #25816
-
- Sep 17, 2024
-
-
This could lead to the "write" method being NULL and used for API 22 and 21. Fixes regression from ccd3eaae
-
Steve Lhomme authored
-
Steve Lhomme authored
We don't need to know what is the actual size.
-
Steve Lhomme authored
We don't need to know what is the actual size.
-
Steve Lhomme authored
We don't need to know what is the actual size.
-
- Sep 16, 2024
-
-
Add an offset of `priv->i_start` during the seek by time operation to correctly account for the start time of individual segmented tracks. Modify the initial value passed to `input_SetTime()` to 0, as the start offset (`priv->i_start`) has already been considered. These changes ensure accurate timing and seek behavior in media files containing segmented tracks, such as those defined by CUE files, by aligning the seek position with the actual timing of individual segments.
-
Calculate the updated position by adding offset according to the current track duration.
-
Update the callers of `vlc_player_UpdateTimer()` to pass an additional `start_offset` argument, representing the start time of the current input item (acting as an offset). Modify the `vlc_player_UpdateTimer()` function to store this start timing in the player timer, ensuring accurate tracking of the playback start position. This change helps maintain correct timing information, particularly when dealing with segmented tracks or CUE files, by ensuring the player's timer aligns with the actual start time of the input.
-
This data member `start_offset` will be used in the next commit to store the start time(which will act as as offset) of the current track so that the current timestamp is adjusted accordingly.
-
Reverts commit c86e464f and bf5b6d59 Add the input_GetItemDuration function, which calculates the duration of a track item based on the start and stop times stored in the input thread's private data. If the stop time is not set, the function considers the provided duration as the stop time; otherwise, it calculates the duration using the start and stop times. Call input_GetItemDuration for retrieving the updated duration of the current track item. The calculated duration is then used to set the player's length accurately.
-
Signed-off-by:Claudio Cambra <developer@claudiocambra.com>
-
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Regression from 08b24866 ``` ==1851678==ERROR: LeakSanitizer: detected memory leaks Direct leak of 12 byte(s) in 1 object(s) allocated from: #0 0x55ab52726322 in malloc (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0xf5322) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #1 0x7fac6d4ed649 in es_format_Copy /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/misc/es_format.c:350:24 #2 0x7fac6d3c2fc9 in decoder_Init /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/decoder_helpers.c:49:5 #3 0x55ab52764362 in decoder_load /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/decoder.c:103:5 #4 0x55ab52764362 in test_decoder_create /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/decoder.c:196:9 #5 0x55ab52762fe5 in EsOutAdd /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/demux-run.c:86:19 #6 0x7fac59c9d0a4 in es_out_Add /home/tom/work/git/vlc/build-fuzzer-asan/modules/../../include/vlc_es_out.h:144:12 #7 0x7fac59c9d0a4 in avformat_OpenDemux /home/tom/work/git/vlc/build-fuzzer-asan/modules/../../modules/demux/avformat/demux.c:702:29 #8 0x7fac6d3c5d0a in demux_Probe /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/demux.c:112:15 #9 0x7fac6d368128 in vlc_module_load /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/modules/modules.c:230:15 #10 0x7fac6d3c5250 in demux_NewAdvanced /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/demux.c:196:20 #11 0x7fac6d3c48b3 in demux_New /home/tom/work/git/vlc/build-fuzzer-asan/src/../../src/input/demux.c:77:12 #12 0x55ab527620d9 in demux_process_stream /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/src/input/demux-run.c:294:22 #13 0x55ab52761c03 in LLVMFuzzerTestOneInput /home/tom/work/git/vlc/build-fuzzer-asan/test/../../test/vlc-demux-libfuzzer.c:54:5 #14 0x55ab52672134 in fuzzer::Fuzzer::ExecuteCallback(unsigned char const*, unsigned long) (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x41134) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #15 0x55ab5265b083 in fuzzer::RunOneTest(fuzzer::Fuzzer*, char const*, unsigned long) (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x2a083) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #16 0x55ab52660ca6 in fuzzer::FuzzerDriver(int*, char***, int (*)(unsigned char const*, unsigned long)) (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x2fca6) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #17 0x55ab5268b796 in main (/home/tom/work/git/vlc/build-fuzzer-asan/test/vlc-demux-dec-libfuzzer+0x5a796) (BuildId: e44569652285bf8bd3c1b21a8e857c36a2185e73) #18 0x7fac6cf2ddb9 in __libc_start_call_main csu/../sysdeps/nptl/libc_start_call_main.h:58:16 ```
-
This is equivalent to the fix in ece317a2 as the aom decoder had the same issue reported in #28776.
-
macosx: Use connected property in abstract segment view controller subclasses to (not) reconnect data sources after long loads if that is applicable Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
macosx: Disconnect/reconnect containers when presenting or dismissing video playback view in library window Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
macosx: Disconnect/reconnect current data source upon receiving video view notifications from library window Signed-off-by: -
Signed-off-by: -
Signed-off-by: -
Signed-off-by:
-
