Skip to content

Draft: Address Layout Consistency Issues

Leon Vitanos requested to merge layout-consistency into master

This MR focuses on achieving concistency in layouts (grid and table view)

Added the ViewHeader QML component, to avoid code duplication, and maintain consistent padding across all layouts. This component provides a title for layouts and includes a "See All" button when necessary. As a result, the BrowseDeviceHeader component has been removed.

Example of a padding inconsisency paddingCorrect paddingWrong
"See All" missalignment in the previous BrowseDeviceHeader seeAllMissalignemnt

Introduced a title header to all Video and Music views (+discovery).

Example before & after musicDoesNotHaveTitle Screenshot_from_2024-02-08_20-55-06

Adjusted the playlistview topPadding to match the layout's padding for uniformity.

Before playqueue

For the table view at the Video page, the ListView.InlineHeader is now only used when we are at the Video page, and there exist recentVideos (basically titles can be scrollable when there are 2 vertically aligned tables)

before & after of seeing all recent videos page Screenshot_from_2024-02-08_20-58-30 Screenshot_from_2024-02-08_20-57-45

Standardized spacing between vertically-aligned grid and list layouts, resolving inconsistencies in spacing between grid and list layouts on the Videos and Browse pages.

Example grid/list spacing difference: griddistance listdistance

Increased top padding of the first layout's title by 8px, and the bottom padding of every layout's title by 4px

Example grid&list padding, before&after: gridOld gridNew

listOld listNew

Reasoning: A comparison with other apps/websites

Title font size seems OK.

font_size

Top padding seems to be too low

top_padding

Bottom padding seems to be too low

bottom_padding

Spacing between vertically-aligned layouts seems OK

spacing

TO-DO:

  • Make layout's title clickable when "See All" button is visible
Edited by Leon Vitanos

Merge request reports

Loading