Skip to content
Snippets Groups Projects
  1. Sep 25, 2022
    • Devin Lehmacher's avatar
      ensure there is a metadata update after last call to needsMetadataUpdate · 81609a6b
      Devin Lehmacher authored
      When metadata updates moved to the background thread this introduced a
      race condition where it was possible for setNeedsMetadataUpdate to be
      called when _needsMetadataUpdate == NO thus skipping the update while
      the action to update the metadata is already being executed on the
      background thread. With a precise interleaving this could leave the
      player metadata in an inconsistent state where it is still displaying
      the metadata from the last song even though the next song has already
      started playing.
      
      This patch ensures that there will always be at least one metadata
      update after the last call to setNeedsMetadataUpdate. It is now possible
      for there to be a redundant metadata update, however if the metadata is
      already up to date this is idempotent thus doesn't lead to an
      inconsistent state. Since the metadata update isn't particularly
      expensive and occurs on a background thread, the cost of an extra update
      in some cases seems reasonable.
      81609a6b
  2. Sep 24, 2022
  3. Sep 22, 2022
  4. Sep 21, 2022
  5. Sep 20, 2022
  6. Sep 18, 2022
  7. Sep 16, 2022
  8. Sep 15, 2022
  9. Sep 14, 2022
  10. Sep 13, 2022
  11. Sep 09, 2022
Loading