Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

It is legal for the media library to send events from any thread so
read and write access to the local cache array must be protected by
locking to avoid concurrency issues.

The view controller's title is updated when the user selects one or
multiple cells in order to give more visibility and improve user
experience.

The checkmark allowing the user to see if a cell has been selected is now
displayed on the left of the cell.

Which is more compliant to the iOS native layout for a list.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

When manipulating the audio and subtitles delays, it is important to
see the video to get it right.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

This is done so that the view no longer overlays the subtitles when the
user is trying to set the delay.

Additionally, this removes 2 stack views with 2 additional spacer views
without changing the layout in anyway.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

While it is rather new, it is the only playback speed view. This commit
is purely cosmetic and does not change any functionality.

Diogo Simao Marques authored 3 years ago and Soomin Lee committed 3 years ago

The UIMenu now recognizes view controllers that are embeded above
the main view controller and performs the actions in the correct
view controller.

Diogo Simao Marques authored 3 years ago and Soomin Lee committed 3 years ago

The UI for the Album View has been refactored in order to improve
the user experience and now includes two new buttons:

1. Play All: to play all the tracks in the album.
2. Play All Shuffle: to play all the tracks in the album in a shuffled way.

Closes #298

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

This prevents cases where the 5 sliders fill the entire screen in
portrait so while manipulating the video characteristics the video
itself might not be seen.

Additionally, this removes a stack view without changing the layout.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

Otherwise, when playing multiple media in a row, the wrong image might
still show if the consecutive media does not have one.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

This also saves 1 UIColor instance. No visual changes.

Closes #1347

Closes #1291

Most of the media library service init failures are caused by
incompatible media library database versions notably due to downgrading
from a future release.

Instead of crashing on launch until the app is deleted by the user
along with its app context and reinstalled, try to delete the database
once to recover.

Handling the metadata can be potentially blocking especially when reading imagery from (remote?) storage, so do not block the main thread for this.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

Previously, remembered information from the last app session was not
restored but just the default values.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

This lists the available profiles in white with the default font face
while the currently selected option is shown in orange and bold.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

The previous implementation was using a mix of UIScrollView and
UIStackView as well as 18 buttons show a list of options.

This improves rendering speed, memory use and reduces LoC by 50%.

Felix Paul Kühne authored 3 years ago and Soomin Lee committed 3 years ago

The previous logic was overly complex to implement a simple lookup and
never stored the enabled state to the settings, just the disabled state.

Querying for all available output devices and then deciding whether
that given route is pointing to an external device can take longer than
the watchdog daemon allows VLC to do a cold start.

Therefore, delay the iteration until the initialization of the
singleton is complete.