Address #13: Free stats objects if there is no callback specified. Also removes unnecessary cppcheck download in ci file.

This reverts commit 77bfe932.

Move all non public facing functions out of rist.c, for now they live in rist-common.c

Set the rtp_seq immediately when we get a packet, simplify send function.

Fixes #12

This PR adds CppCheck and Clang static code analysis on build. It will run either or both depending on availability. Since we do not have an image yet for librist it'll probably just be CppCheck to start (this is being downloaded manually).
I've also made a few code changes that are noteworthy in non-rist code:

1. aes.c: made aes_key_setup return an error result if the key size is invalid. Clang discovered a path in which it was possible for an invalid key size to be fed in and garbage values could be used in de/encryption.
2. lz4hc.c: LZ4_initStreamHC can fail, but failure was not checked in LZ4_createStreamHC, meaning the system could continue with garbage data.
3. lz4frame.c: LZ4F_updateDict Add a null check for dctx->dict || dctx->tmpOutputBuffer since if either of them are null it leads to bad behaviour or a crash. This may be a false positive though since calling this function should be done on correctly-initialised data.

This addresses #9

james h authored 5 years ago and Sergio Ammirata committed 5 years ago

Signed-off-by: Sergio Ammirata <sergio@ammirata.net>

james h authored 5 years ago and Sergio Ammirata committed 5 years ago

Signed-off-by: Sergio Ammirata <sergio@ammirata.net>

james h authored 5 years ago and Sergio Ammirata committed 5 years ago

Add a basic Gitlab CI pipeline, add a single failing unit test, increase warning levels, add error on warning, fix warnings.

Signed-off-by: Sergio Ammirata <sergio@ammirata.net>

Add missing constants and rename rist_receiver_oob_set to rist_receiver_oob_callback_set for consistency

Fix bug where the rist_parse_address was returning an invalid pointer back to the app (NULL peer_config input case).