Hugo Beauzée-Luyssen authored 5 years ago and Hugo Beauzée-Luyssen committed 5 years ago

Fix #237

Hugo Beauzée-Luyssen authored 5 years ago and Hugo Beauzée-Luyssen committed 5 years ago

when creating groups by media id

Which will be used by the missing index schema checks

We now require all migrations to create all individual tables, triggers
or indexes. This mean the createTables/createTriggers/createIndex
functions always create all tables/triggers/indexes at the current
version, which in turn means there's no use for the additional
parameter, nor do we need to create old schemes.

This reverts 1cfef937
Fix #234

refs #234

Fixes the build with mingw64 in winrt mode.

So that 3rd parties device listers also get them

And restore them when they reappear, once the appropriate device lister
are started

All background services are now started lazily

Only on explicit use for now

Since it now does those 2 things. This also clarifies the distinction
between this method and refreshDevice( fs::IFileSystemFactory& )

Only start them when network discovery is enabled

Instead of relying on a dedicated task, to be run only once as the first
task, just call the function directly & automatically.

Now that we lazily start the discoverer worker, we can start its
associated thread sooner.
This will help when we start delegating the device refresh to the
discoverer background thread

We don't need a full instance, all we care about is for the instance to
handle tasks being enqueued
This will allow us to automatically start the thread for the real
instance, but not for unit tests

One locked version, one public unlocked version

So return void instead of a bool

This is a valid case on platforms that don't have a default device
lister.

One locked & one public, unlocked

Since on iOS we use a specific DeviceLister, there is no need
to build the macOS one.