* Use the external preparser in the playlist and in the medialib
   thumbnailer.

 * Add a new backend to preform preparsing by sending preparser request
   to an external process and wait for the preparsed media in a
   preparser responce format.

 * Use the new preparser with external process inside the playlist and
   the medialib thumbnailer.

 * Check if VLC_PREPARSER_PATH exist, if not set it to
   `TOP_BUILDDIR/bin/vlc-preparser-static`.

Gabriel Lafond-Thenaille authored 4 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Create an external process that receive preparser request, use the
   original preparser to preparse the media and the send it back as
   preparser responce.

 * Change the preparser to a module like interface with operations.

 * Move vlc_preparser_New at the end of the file to recude diff with the
   next commit.

 * Rename `src/preparser/preparser.c` to `src/preparser/internal.c` to
   keep git history when the new external preparser will be added.

Gabriel Lafond-Thenaille authored 4 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Create a module to serialize and deserialize preparser message in
   JSON.

Gabriel Lafond-Thenaille authored 3 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Create a preparser IPC (preparser request and responce) in order to
   sending preparser request to an other process and get back the
   preparsed media.

 * Create a de/serialization module capability to serialize and
   deserialize preparser message (request or responce).

Gabriel Lafond-Thenaille authored 3 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Create an API to spawn a process, control it and communicate with it
   though pipes.

Gabriel Lafond-Thenaille authored 5 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Force the size of the `YY_READ_BUF_SIZE` to `1 << 22` and the size of
   `YY_BUF_SIZE` to `YY_READ_BUF_SIZE * 2`.

Gabriel Lafond-Thenaille authored 7 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Add two getter function on the meta API, `vlc_meta_GetWithPriority`
   and `vlc_meta_GetExtraWithPriority`.

Gabriel Lafond-Thenaille authored 4 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Add the function `input_item_node_Copy` that make a copy of the whole
   tree of subitems. As the original tree the new one hold a reference of
   each input item of the tree.

Gabriel Lafond-Thenaille authored 6 months ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Create a function to Update input item from an other one. This function
   updates the value: `psz_name`, `psz_uri`, `i_duration`, `es_vec` and
   `p_meta`.

 * Now `es_vec` (`struct input_item_es`) is copied by
   `input_item_Copy`

Gabriel Lafond-Thenaille authored 1 month ago and Gabriel Lafond-Thenaille committed 5 days ago

 * Replace the CRT _pipe function with proper named pipe With OVERLAPPED
   flag to add async IO support.

This fixes linking with llvm-mingw (or any mingw distribution that
doesn't default to linking in winpthreads).

This wasn't noticed in the upstream VLC CI, as it builds with
extras/packages/win32/build.sh, which passes in -Wl,-l:libpthread.a
in VLC_LDFLAGS (in order to prefer linking winpthreads statically,
rather than dynamically, for libraries that do use winpthreads).

This patch has been sent upstream in
https://github.com/xiph/flac/pull/832.

"This release finally makes the encoder multithreaded! Furthermore, the decoder can now handle chained Ogg FLAC files. As always, a lot of things have been fixed and improved."

The relevant patches have been upstreamed and the microbench tool has been dropped.

Prince Gupta authored 8 months ago and Steve Lhomme committed 1 week ago

fixes related warnings as well

Tristan Matthews authored 1 week ago and Steve Lhomme committed 1 week ago

It seems like a new release tarball was pushed with the same version.

Fatih Uzunoğlu authored 1 week ago and Steve Lhomme committed 1 week ago

Since calloc is used, this variable remains false and this
prevents calling `xdg_toplevel_show_window_menu()`.

Fatih Uzunoğlu authored 2 weeks ago and Steve Lhomme committed 1 week ago

Currently the interface only provides "video" and "audio"
playlists. Mixed playlists don't seem to be presented.
This is something that can be handled trivially with drag
and drop case.

Adding to playlist action in context menu is more of a
problem, because in that case there is no specific open
playlist view that we can pick as the target.

I'm not sure what is the best behavior with regard to
the latter situation, but I assume we need to segregate
there too, because if the user can not make use of a
mixed playlist, there is no point creating them or
appending media.

I followed a naive approach, simply used `showPlayAsAudioAction`.
However, it could be possible to:
- If there is a single item, check if it is audio or video, and
  pick the appropriate type playlist.
- If there are multiple items, always pick `PLAYLIST_TYPE_ALL`.
- If there are multiple items, iterate through all items, and
  if all of them are the same, pick the appropriate playlist
  (i.e. video, or audio playlist), if there are different type
  of items, pick `PLAYLIST_TYPE_ALL`.

Fatih Uzunoğlu authored 2 weeks ago and Steve Lhomme committed 1 week ago

Dialogs that carry the state of their initiators
should not be singleton. In this case, this dialog
always needs some sort of media to be functional.

This is already the case with the media info
dialog, for example, current media info dialog
is a singleton but media info dialog of a specific
media is not.

Since this dialog is always tied to some specific
media, I see no point of this being a singleton.
Its title suggests that this dialog is only meant
to be used for adding items to an existing or new
playlist.

Asynchronousity is also a problem when it is a
singleton, what happens if the user wants to add
items before the previous (asynchronous) addition
is not complete yet?

Fatih Uzunoğlu authored 2 weeks ago and Steve Lhomme committed 1 week ago

- `QDialog` already handles this.
- The implementation is not correct here,
  enter key should accept the dialog. It is
  also not clear why a dialog specific `reject()`
  is not called when encountering escape key.

Fatih Uzunoğlu authored 1 month ago and Steve Lhomme committed 1 week ago

and set missing display margin end.

Alaric Senat authored 2 months ago and Steve Lhomme committed 1 week ago

The core unsafe bindings aren't needed anymore outside the scope of the
bindings.

Alaric Senat authored 2 months ago and Steve Lhomme committed 1 week ago

Introduce a lightweight safe `TraceValue` wrapper of the VLC tracer
tagged union.

Alaric Senat authored 2 months ago and Steve Lhomme committed 1 week ago

See trait documentation for extended context.