Co-authored-by: Mehdi Sabwat <mehdi@videolabs.io>

Co-authored-by: Mehdi Sabwat <mehdi@videolabs.io>

Co-authored-by: Mehdi Sabwat <mehdi@videolabs.io>

Alexandre Janniaux authored 7 months ago and Steve Lhomme committed 7 months ago

    CXX      dialogs/systray/libqt_plugin_la-systray.lo
    ../../../../modules/gui/qt/dialogs/systray/systray.cpp:101:21: error: no member named 'updateSystrayMenu' in 'VLCMenuBar'
            VLCMenuBar::updateSystrayMenu( this, p_intf );
            ~~~~~~~~~~~~^
    ../../../../modules/gui/qt/dialogs/systray/systray.cpp:101:46: error: use of undeclared identifier 'p_intf'
            VLCMenuBar::updateSystrayMenu( this, p_intf );
                                                 ^

Thomas Guillem authored 7 months ago and Steve Lhomme committed 7 months ago

first_pts was not taken into account when using getPlaybackHeadPosition
(Before SDK 19).

Regression from b42481c7

Claudio Cambra authored 7 months ago and Felix Paul Kühne committed 7 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 7 months ago and Felix Paul Kühne committed 7 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Claudio Cambra authored 7 months ago and Felix Paul Kühne committed 7 months ago

Signed-off-by: Claudio Cambra <developer@claudiocambra.com>

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

- QQuickWindow should not clear focus when it loses focus (QTBUG-125309).
- Qt 6.5 is able to re-focus the previously focused item, when the window is
  re-activated.
- Qt 6.2 does not set the focus item when the window is re-activated. This causes
  issues with key event delivery, and therefore key navigation.

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

Since the label is removed from the general tab due to lack
of space, it is now displayed in the extra meta data tab.

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

Keeping this is a problem to make the artwork vertically centered.

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

Having this public does not make sense, because there
is already the input item. Having this method public
enables synchronization issues (different art than
the art associated with the input item).

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

if there is no input item, context menu is not relevant therefore should not
be shown.

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

so that it becomes aligned with the cover art

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

so that in normal cases its width becomes equal to cover
art's width

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

Hiding it makes the cover art appear unsymmetrical.

Fatih Uzunoğlu authored 7 months ago and Steve Lhomme committed 7 months ago

Instead of wasting space, comments text edit can expand and use
the available space. This should not be a problem, since it is
the last text edit.

Pierre Lamot authored 7 months ago and Steve Lhomme committed 7 months ago

mapping can be centralized, no need for an additional QObject

Pierre Lamot authored 7 months ago and Steve Lhomme committed 7 months ago

it's only owned and accessed by the ExtensionsManager

Pierre Lamot authored 7 months ago and Steve Lhomme committed 7 months ago

* either we are in extension thread and this is safe to carry the extension_dialog_t
  through queued connection as the extension wait that we signal its condition
  variable

* either we are in Qt thread (during destruction for instance) and we want
  direct connection

Pierre Lamot authored 7 months ago and Steve Lhomme committed 7 months ago

no need to rely on singleton feature of the class to retreive the instance

Pierre Lamot authored 7 months ago and Steve Lhomme committed 7 months ago

these macro where here for older Qt5 compatibility, they are not needed anymore

For safety reasons some users may not want to handle any chapter codec.
The option was added 8697e6ef but
never implemented.