- May 02, 2025
-
-
-
Currently the interface only provides "video" and "audio" playlists. Mixed playlists don't seem to be presented. This is something that can be handled trivially with drag and drop case. Adding to playlist action in context menu is more of a problem, because in that case there is no specific open playlist view that we can pick as the target. I'm not sure what is the best behavior with regard to the latter situation, but I assume we need to segregate there too, because if the user can not make use of a mixed playlist, there is no point creating them or appending media. I followed a naive approach, simply used `showPlayAsAudioAction`. However, it could be possible to: - If there is a single item, check if it is audio or video, and pick the appropriate type playlist. - If there are multiple items, always pick `PLAYLIST_TYPE_ALL`. - If there are multiple items, iterate through all items, and if all of them are the same, pick the appropriate playlist (i.e. video, or audio playlist), if there are different type of items, pick `PLAYLIST_TYPE_ALL`.
-
Dialogs that carry the state of their initiators should not be singleton. In this case, this dialog always needs some sort of media to be functional. This is already the case with the media info dialog, for example, current media info dialog is a singleton but media info dialog of a specific media is not. Since this dialog is always tied to some specific media, I see no point of this being a singleton. Its title suggests that this dialog is only meant to be used for adding items to an existing or new playlist. Asynchronousity is also a problem when it is a singleton, what happens if the user wants to add items before the previous (asynchronous) addition is not complete yet?
-
-
- `QDialog` already handles this. - The implementation is not correct here, enter key should accept the dialog. It is also not clear why a dialog specific `reject()` is not called when encountering escape key.
-
-
-
-
and set missing display margin end.
-
-
-
- Apr 29, 2025
-
-
The core unsafe bindings aren't needed anymore outside the scope of the bindings.
-
Introduce a lightweight safe `TraceValue` wrapper of the VLC tracer tagged union.
-
See trait documentation for extended context.
-
Use `fold` to avoid two iterations over the entries while keeping the functional code style.
-
Introduce a small accessor to the entries that communicates the intent better than `into_iter()`.
-
-
Since `Trace` is a wrapper around the VLC tracer object. `entries` as a name was not actually giving access to trace entries but to the internals of the object.
-
Reserve the sys module for raw VLC bindings. The moved abstraction are meant to be transformed into safe encapsulations of sys content.
-
These should not be considered as documentation, in some cases, it messes with the formatter and possibly rust-doc.
-
refs streams/ts/1fps93hours.ts
-
-
Can never work with timestamp value 0
-
-
-
-
-
-
-
- Apr 28, 2025
-
-
This fixes a warning during build Signed-off-by:Claudio Cambra <developer@claudiocambra.com>
-
This is because `itemContainsDrag` may be undefined or null, which is observed when the list is empty. With the chaining operator, the evaluation yields undefined, and then the function can handle the passed undefined index (which is already the case here with `acceptDropFunc`, where `DialogsProvider.playlistsDialog()` is called when the passed index is undefined).
-
Akin to 1d10b736.
-
- Apr 27, 2025
-
-
-
The extra rectangles are useless because `ImageExt` can already do what they are doing.
-
-
-
-
This customization has been broken for a while, I have not previously tried to fix it because there were plans of getting rid of it (at least, the case with horizontal list view). However, not only the buttons still remain there, but it is now also used in more places (be87f3ea). Customization is not worth it if the control is never or barely used as in these cases we can simply rely on Qt Quick Basic style directly, and adjust the palette and sizes and be done with it. Note that, we can expect Qt Quick Controls Basic style to be available as long as Qt Quick Controls itself is available (which we require). This means that we should be able to freely import the `QtQuick.Controls.Basic` QML module.
-
This patch updates the status URLs and key directory URL to use HTTPS instead of HTTP. Signed-off-by:William Woodruff <william@trailofbits.com>
-
This patch updates the URLs for contrib retrieval from HTTP to HTTPS, where possible. URls that could not be moved to HTTPS are marked with an XXX comment. One domain is additionally changed: libsamplerate is now retrieved from the libsndfile organization on GitHub instead of mega-nerd.com, as the latter does not offer HTTPS. The former was confirmed for release integrity against the latter and was cross-checked as the living source for libsamplerate against Homebrew and Arch Linux, both of which use theGitHub organization. Signed-off-by:
-
