- Aug 24, 2023
-
-
Marvin Scholz authoredChecking i_extra is redundant here as it is always > 0 in this if-branch. Instead apparently it was intended to check for allocation success here, to avoid crashing when doing a memcpy with a NULL destination.
-
Marvin Scholz authored
Fixes warnings for comparing integers of different signedness.
-
- Aug 23, 2023
-
-
Steve Lhomme authored
-
Steve Lhomme authored
-
Steve Lhomme authored
-
Steve Lhomme authored
-
Steve Lhomme authored
-
Steve Lhomme authored
In case the caller doesn't force its own mask for formats with a mask. If it did, it was after the call to video_format_Setup() so it would still overwrite the "default" value.
-
To include the following commit that was causing high CPU usage on vlc-ios: miniserver: fix busy loop on socket error In case of a socket error, the socket was not removed from the select pool, causing future select() calls to return immediately, and readFromSSDPSocket() to be called just after on the failing socket. This was causing a high CPU load.
-
- Aug 22, 2023
-
-
...instead of the private interop include. The interop.h include also contains functions to create interop objects, that we don't use in the sub_renderer, whereas vlc_opengl_interop.h contains every public structure and functions.
-
The header was not used anymore.
-
The file was renamed to filters.c since it was specifically designed to test the code from opengl/filters.c, but I forgot to change the header.
-
The test draws a 2x2 subpicture region on top of a 4x4 framebuffer. Each pixel is different on the subpicture, which allows to check the orientation and position of the subpicture according to the surface orientation. libplacebo is linked into the tests for now, since it seems the tests need it transitively, but it should not be needed in the long run. See the link error below: /usr/bin/ld: ../modules/video_output/opengl/test_modules_video_output_opengl_sub_renderer-sub_renderer.o:(.data.rel.ro+0x8): undefined reference to `pl_filter_spline16' /usr/bin/ld: ../modules/video_output/opengl/test_modules_video_output_opengl_sub_renderer-sub_renderer.o:(.data.rel.ro+0x10): undefined reference to `pl_filter_spline36' /usr/bin/ld: ../modules/video_output/opengl/test_modules_video_output_opengl_sub_renderer-sub_renderer.o:(.data.rel.ro+0x18): undefined reference to `pl_filter_spline64' /usr/bin/ld: ../modules/video_output/opengl/test_modules_video_output_opengl_sub_renderer-sub_renderer.o:(.data.rel.ro+0x20): undefined reference to `pl_filter_mitchell' /usr/bin/ld: ../modules/video_output/opengl/test_modules_video_output_opengl_sub_renderer-sub_renderer.o:(.data.rel.ro+0x28): undefined reference to `pl_filter_bicubic' ... -
The OpenGL surface can expose an orientation, which is used by the renderer.c code, but it wasn't used by the sub_renderer yet. This commit specify how to transform the vertex coordinates, and for simplicity the texture coordinates, whatever the orientation is.
-
VideoToolbox decoder doesn't attach all color properties to image buffers. Current display modules handle tonemap without them. Attaching additional color properties to image buffers is mandatory for native image buffer display on macOS in order to have proper colors tonemap when AVFoundation APIs are used to render them and prevent flickering while using multiple displays with different colorsync profiles
-
Steve Lhomme authored
The libplacebo display has 9 usable values.
-
Steve Lhomme authored
-
Steve Lhomme authored
-
Steve Lhomme authored
-
- Aug 21, 2023
-
-
-
vlc_tick_t is used here and cannot be forward-declared.
-
vlc_tick_t is used here and cannot be forward-declared.
-
vlc_gl_t is referenced by the vlc_gl_interop structure, but only as a pointer. Avoid including <vlc_opengl.h> and provides a forward-reference.
-
video_format_t is defined in vlc_es.h and is used by the header.
-
To avoid creating constructors with C++ linkage.
-
-
The tests are not run and are only compiled to object, without linkage. It's pretty fast, and would help noticing when a forward declaration or an include is missing from one of the files.
-
The $(extra_check_verbose_0) was missing a semi-colon at the end since the commit 53f6d534 introducing it, so it was probably never used nor tested.
-
-
-
-
-
-
-
Otherwise, the header cannot be included as a standalone header.
-
-
Steve Lhomme authored
If the mask corresponds exactly, we have an exact match. If the RGB source has a mask but none of the RGB mapping uses the same mask, we map to a close RGB format with a different mask. It's better than using the first VLC_CODEC_RGBxx in the list if there's one corresponding to the exact match. Another option would be to move the VLC_RGB_ES() calls at the end of the list.
-
Steve Lhomme authored
No need to use a pointer and an error code for that.
-
Currently emscripten builds all its libraris statically. This commit will make necessary changes to the build script to make it possible. The shared module based building can be triggered with the parameter --enable-emscripten
-
Currently libtool.m4 does not have information about wasm32-unknown-emscripten in host_os. Which causes failure in enabling shared libraries. This patch will create a new host_os case named emscripten in libtool.m4 to allow us to enable shared library compilation and add emscripten specific shared library building flags. This patch will also add some shared library configuration in libtool for emscripten host.
-
