Martin Storsjö authored 11 months ago and Steve Lhomme committed 11 months ago

The asdcplib code contains a C++ template which refers to member
variables that doesn't exist. Earlier, this hasn't been an issue,
as the C++ template never is instantiated, but current Clang
versions (the upcoming 19.x version) diagnoses such issues already
before the class is instantiated, leading to compilation errors
on the asdcplib code.

This applies https://github.com/cinecert/asdcplib/pull/137 (which
hasn't yet received any attention), fixing
https://github.com/cinecert/asdcplib/issues/136.

Fatih Uzunoğlu authored 11 months ago and Jean-Baptiste Kempf committed 11 months ago

KF6WindowSystem requires Qt6Gui, but not Qt6Core.
And Qt6Gui does not require Qt6Core.

The symbol `qt_version_tag` is available in Qt6Core.

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 11 months ago

DirectWrite should work better on Windows, and
static linking to FreeType increases the size
considerably.

Fatih Uzunoğlu authored 11 months ago and Steve Lhomme committed 11 months ago

Here, the root window is supposed to be the screen's root window.

Fatih Uzunoğlu authored 11 months ago and Steve Lhomme committed 11 months ago

A convenient control, designed to be
used as a progress indicator.

Contains a text alongside a busy
indicator, with round rectangular
semi-translucent background.

Khalid Masum authored 11 months ago and Jean-Baptiste Kempf committed 11 months ago

Currently, when creating lua.pc, unwanted strings are added into the
file, for example, inspecting a lua.pc file from
$PREFIX/lib/pkgconfig/lua.pc gives:

make[2]: Entering directory 'foo/bar'
<intended lua.pc content here>
make[2]: Leaving directory 'foo/bar'

Mitigate this by using --no-print-directory flag when running the internal
make command from its Makefile.

Khalid Masum authored 11 months ago and Jean-Baptiste Kempf committed 11 months ago

If $PREFIX/lib/pkgconfig/ directory already not created, lua puts lua.pc
as $PREFIX/lib/pkgconfig file. Therefore $PREFIX/lib/pkgconfig cannot be
created or used by any other contrib tools.

This causes various other tools that need to put pkgconfig in that
directory (including lua itself) fail to finish the building process.

Fix this by creating a pkgconfig directory if it does not exist before
lua build tries to copy pkgconfig there.

Prince Gupta authored 11 months ago and Steve Lhomme committed 11 months ago

fixes wheel scrolling in Video view and Browse view

disable interaction in ExpandView if content fits
this allows correct handling of wheel scrolling by the main view

Marvin Scholz authored 11 months ago and Steve Lhomme committed 11 months ago

Fixes a warning about the implicit conversion of enum type:
  implicit conversion from enumeration type 'enum CGImageAlphaInfo'
  to different enumeration type 'CGBitmapInfo'

Marvin Scholz authored 11 months ago and Steve Lhomme committed 11 months ago

OpenGL is deprecated, nothing we can do about that, so might as well
silence the deprecation warnings for it to not clutter the build log
and drown out actually relevant warnings.

Marvin Scholz authored 11 months ago and Steve Lhomme committed 11 months ago

Fixes warning: variable 'i_vote_invalid' set but not used

Marvin Scholz authored 11 months ago and Steve Lhomme committed 11 months ago

Fixes compiler warning about missing prototype and also this function
is only ever used in this file.