This also removes 3 patches that are no longer needed.

When the player is changing state, the delegate doesn't care about
receiving an NSNotification or knowing from which player it was
triggered, but it will need to know the new state from the player.

It prevents calling libvlc methods from the callback, which is usually
forbidden and works only because of the dispatch_async.

The event signalling a change of media length is not a state change and
should be reported separately with the correct metadata.

Add mediaPlayerTrackSelected API to signal changes reported from the
libvlc_media_player_t object. For now, it mimics the API, by just
transforming raw char strings into NSString, but it should be improved
to report VLCMediaTrack instead.

The blocker for reporting VLCMediaTrack is that libvlc_media_track_t are
not reported by the media player as events currently, so it's not
possible to get a matching libvlc object, which makes it impossible to
get the matching VLCKit object without duplicating them.

Add mediaPlayerTrackAdded/Updated/Removed API to signal changes reported
from the libvlc_media_player_t object. For now, it mimics the API, by
just transforming raw char strings into NSString, but it should be
improved to report VLCMediaTrack instead.

The blocker for reporting VLCMediaTrack is that libvlc_media_track_t are
not reported by the media player as events currently, so it's not
possible to get a matching libvlc object, which makes it impossible to
get the matching VLCKit object without duplicating them.

Soomin Lee authored 2 years ago and Alexandre Janniaux committed 2 years ago

ESAdded/Delete are not VLCMediaPlayer states.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

`parseWithOptions` is provided through multiple selectors allowing
default values to be provided in most cases. Refactor the documentation
so that the specialized variants are referencing the more general
variant and document the most general one.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

Expand the usual macro found in Objective-C to ensure doxygen can parse
the types correctly:

 - NS_OPTIONS() and NS_ENUM types are correctly parsed and referenced by
   doxygen, so the \see <an_enum_type> is now creating a reference link.

 - NS_SWIFT_NAME() is not clobbering the doxygen reference anymore.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

A libvlc_event_attach call must have a matching libvlc_event_detach call
to ensure that the event is removed, otherwise libvlc will assert when
destroying the object.

Having the attach/detach being in two different location can mask that
they should be removed when adding a new handler for a new event, so it
makes sense to gather everything in a single table like done in the
commit 9db4f9c5.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

Ensure that we have a fully initialized object after [VLCMedia init*]
function returned. It allows to remove every location defensively
checking whether p_md was assigned or not.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

This reduces the number of indentation needed to every initialization
locations. The [super init] must be called to initialized the object
correctly and is documented as returning nil in case the initialization
failed.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

Now that preparsing doesn't depend on a library assigned to the VLCMedia
object but directly from the libvlc_instance_t used, the user might want
to alter the parameters by providing their own VLCLibrary object, until
a better API is made for VLCKit.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

Refactor in VLC 4.0 removed the libvlc_instance_t parameter to most
functions from libvlc_media_t (in particular constructor) and only kept
it for preparsing/thumbnailing requests.

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

VLC 4.0 now has an inhibiter module for UIKit and doesn't need the
idleTimer control. In addition, the control was using libVLC methods
from the callback, enforcing dispatch_async to be used.

test works correctly when quoting the strings already.

Fix the build when -a is used to select an arch that is not buildable
on either simulator or device, but available on the other, which led
lipo to complain that no files were given as input.

Since the previous archives are removed, and probed, it doesn't impact
the generation of the framework.

Example: ./compileAndBuildVLCKit.sh -ftnva aarch64

Refactor the checks to create the lipo-ed build for each target from
each target/arch couple behind a single function. Because of the
discrepancy between VLCKit buildsystem (expecting ${os_style}-simulator-
or ${os_style}-device- prefix) and the way VLC defines the target (which
is directly ${os_style}simulator or ${os_style}os) and the additional
discrepancy against macosx (which is not -os suffixed), some additional
code is made to make them match correctly by checking whether we run in
simulator or for device.

This makes the compilation of the ARMv7 slice option, which fixes
compilation support with Xcode 14 by default. Allowing optional support
still enables the use for legacy platforms. For CI and official
releases, the ARMv7 slice is still compiled by default.

Fixes #655

Alexandre Janniaux authored 2 years ago and Felix Paul Kühne committed 2 years ago

Add selectedExclusive property on tracks to select a track while
disabling the other tracks of the same kind.

Seemed the project wasn't updated to support VLCKit dynamic linking and loading.
This patch embeds the framework and fixes the rpath