This is temporary and should be reverted ASAP.
There's currently an unknown libvlc issue with the win32/64
implementations of the thumbnailer. This issue is being investigated
but shouldn't block all our pipelines.

Failures under windows pipelines shouldn't be ignored and it is better
not to disable the thumbnailer tests, so lets switch the failing jobs to
warnings and check them manually when they fail...

Thomas Guillem authored 2 years ago and Alaric Senat committed 2 years ago

This will disable the following feature:
https://github.com/chouquette/meson/commit/788e8002993e0a14af8f6bd75aba3bfc9fed7d80

Steve Lhomme authored 2 years ago and Alaric Senat committed 2 years ago

A newer libvlcpp is needed.

There seems to be no justifications to provide a custom count query.
Removing it simplifies a lot the code and allow for easier
QueryParameters support.

To `favoriteOnly` to be more in line with the rest of the
implementation which already used the `favorite` termination.

No functional changes.

Which allows more queryParameter support like `includeMissing` and
`favoriteOnly` effortlessly.

To follow the usual space-before rules and support more QueryParameters
conditions.

This remove the sorting and joining boiler plate code.

To allow selecting the default `SortingCriteria` which was annoying to
do beforehand because of the `const` nature of the `QueryParameters`.

This will be useful to set `Album` sorting as a default for `Artist`
tracks listing.

This is extracted from the Album track listing method which was likely
more used and correctly implemented.
The new sorting technique just take into account album IDs and disc
numbers.

Implements #455

Implements #464

Implements #458

Refs #458

Implements #457

Alaric Senat authored 2 years ago and Alaric Senat committed 2 years ago

Implements #461