Diogo Simao Marques authored 1 year ago and Felix Paul Kühne committed 1 year ago

The favorite feature has currently been designed to be supported only on iOS.

Therefore the favorite variables are properly configured only on iOS, avoiding
crashing the application while navigating through network local shares on tvOS.

Closes #1747

An alert has been added to confirm the action of clearing the history
in order to avoid any unintentional destructive action.

Closes #1746

The media group's view can be closed after emptying the group with the "remove"
edit action.

The edit state information needs to be propagated in order to properly update
the interface.

The edit state is properly updated after an action is performed.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Fixes #1691

This fixes a regression regarding the now playing animation.

The collection view is properly reloaded when necessary in order to
display the currently playing media.

This fixes #1742

Fixes #1737

This new replacement in C is 13x faster than before.

Use a boolean compare instead of a local variable.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

in order to support the Xcode 13 CI

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

This ensures that if the user was searching while editing, the editing status stays.
It also ensures that the search bar is not erroneously greyed out after an action (rename / delete / etc)

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Prevents user from selecting an item, searching something else, and accidentally deleting an item they forgot they'd selected before (hidden by new search)

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Causes the UI to update and hide the deleted media when on the search page.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

MediaCategoryViewController: Abstract the data-set to a computed variable that decides depending on isSearching value.

Additionally, shift isSearching to the LibrarySearchDataSource so both collectionView datasources (MediaCategoryViewController and EditController) have their isSearching value in sync.
Prevents edge cases when searching while editing where search results don't update

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Better than previous way to define MediaCategoryViewController's scrollViewDidScroll method in the editController extension.
Done by casting delegate to MediaCategoryViewController

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Search While Editing: scrollViewDidScroll behaviour in editController mirrors that of non-edit mode.

Behaviour with searchbar stays the same whether editing or not.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Additional UI fixes to prevent searchbar from covering the collectionview.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Necessary to prevent bug where navbar buttons occasionally turn hidden when isEditing and isSearching both are true.
This is because previous func would check the empty collectionview, while the searchdata was populated.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Computed property to return correct set of data to use. Based on boolean isSearching.

Avi Wadhwa authored 1 year ago and Felix Paul Kühne committed 1 year ago

Check isSearching before using searchDataSource or model.anyFiles
This mimics the MediaCategoryViewController behaviour in EditController.
Still a work in progress because of a lot of UI glitches.

Rizky Maulana authored 1 year ago and Felix Paul Kühne committed 1 year ago

and fixed UserDefaults initializers on FavoriteVC

Rizky Maulana authored 1 year ago and Felix Paul Kühne committed 1 year ago

added Favorite Icon and removed whitespaces and empty lines