Fix #280

When we receive a device mounted notification before the discoverer is
started, we can't reload the device immediatly as the discoverer
instance is still null.
We also don't need to do so since the discoverer will reload all devices
as its first task when the thread starts.

Fix #279

Otherwise the likelyness of failing early in the application lifetime is
quite high.

Since we'll use the same code somewhere else soon

This way we can work around the fs factory not being started when a
removable file/folder MRL gets fetched early in the application lifetime

As it causes build failures on android (on API level < 21 at least)

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

We now prioritize embedded cover over cover files. Different embedded
cover will be differenciated by their MD5 sum.
This is also fixing thumbnail assignment for unknown albums & unknown
artists.
Refs #271
Fix #272

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

So we can save it only when the thumbnail is used, or discard the
in-memory buffer otherwise

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

We'll soon start monitoring more than a single event, so let's prepare
the code for that by not having to manually unregister things and store
multiple RegisteredEvent instances

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

That will represent an embedded thumbnail as fetched by the metadata
extractor.
The thumbnails will come from libvlc and we can't propagate a
dependency on libvlc outside of the extractor, and need to have
something to keep a reference to the object VLC returns us

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

refs #271

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

Refs #271

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

refs #271

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

Fix #272

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

If a thumbnail ends up being used, we will insert it in database. If it
hasn't been inserted, we don't need to relocate it

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

Instead of doing it inconditionally, we let Thumbnail::updateOrReplace
handle the insertion in database.
This prevents inserting a thumbnail in database if it isn't actually
used by any entity

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

This way we know if we need to create it, which allows for logic
specific to the album creation to kick in
refs #272

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

refs #272 & #271

Hugo Beauzée-Luyssen authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

Regression of 1617f855

Fix #275

refs #270

refs #270

Jonas Mueller authored 4 years ago and Hugo Beauzée-Luyssen committed 4 years ago

Fix #266
Signed-off-by: Hugo Beauzée-Luyssen <hugo@beauzee.fr>