It builds fine. Not sure why it was disabled.

And don't return a constant value.

There was a leak when called from exec_DeleteImage(). It was removed from the
list/vector but the structure was not released and once the pointer is
removed from the list, it's not referenced elsewhere.

We can just handle the vector locally.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Switching to `vlc_vector_t` made it possible to handle memory failures.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

To also handle the last ID in the for loop.

No functional changes.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Frame chains are not supported anymore in sout's `pf_send`.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Storing NULL duplicated IDs was necessary before we had a reference to
the duplicate stream output stored with the duplicated id. Storing NULL
allowed to have an index equivalence between the stream array and the ID
array.

Now that IDs can be independently stored, lets remove the NULL pushes
and the unneeded NULL checks!

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Module opening and closure are already generically printed.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

The select chain can be assigned by accessing the last element of the
vector directly.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Will make it easier to expand fields stored per duplicated streams and
save one malloc and free calls per duplicated streams.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Switch from the legacy `TAB` API to the new vector implementation.
The vectors here will help:
- refactoring the code and get rid of a lot of index based access (with
  foreach loops mainly)
- check for allocation errors (`TAB_...` aborts on malloc failure)

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

For storage of types larger than native types a ref based iterated loop
is handy to avoid copy.

Alaric Senat authored 1 year ago and Steve Lhomme committed 1 year ago

Accessing the last element of a vector is a common operation.
Having it named and bound checked would definetely be a plus for
`vlc_vector` usage. It avoids error-prones index accesses.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

It was only used from ES_OUT_GET_PCR_SYSTEM, that is now removed, cf.
previous commit.

Thomas Guillem authored 1 year ago and Steve Lhomme committed 1 year ago

It was only used for the netsync module that is not (yet) implemented in
VLC 4.0. Nevertheless, the netsync module should use the vlc_clock_t API
and not these 2 controls.

The i_visible_pitch is not used here. We should not modify the incoming
pictures.

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

    src/input/input_internal.h:312: warning: argument 'events_cb' of command @param is not found in the argument list of input_Create(vlc_object_t *p_parent, input_thread_events_cb event_cb, void *events_data, input_item_t *p_item, enum input_type type, input_resource_t *p_resource, vlc_renderer_item_t *p_renderer)
    src/input/input_internal.h:312: warning: The following parameter of input_Create(vlc_object_t *p_parent, input_thread_events_cb event_cb, void *events_data, input_item_t *p_item, enum input_type type, input_resource_t *p_resource, vlc_renderer_item_t *p_renderer) is not documented:
      parameter 'event_cb'

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

    include/vlc_objects.h:109: warning: The following parameter of
        vlc_object_create(vlc_object_t *p_this, size_t i_size) is not
        documented: parameter 'p_this'

Alexandre Janniaux authored 1 year ago and Steve Lhomme committed 1 year ago

 - missing parameter name
 - \return on void function sout_StreamIdDel

Text-to-speech renderers don't set a new chroma on the output since they
don't create an actual picture.

The code before 7fef0ec0 was returning if the
chroma wasn't changed, which is fine for Text-to-speech. There is no picture
to place.

That allows more flexibility in the choice of container.