Skip to content
Snippets Groups Projects
  1. May 14, 2024
  2. May 07, 2024
    • Simon Latapie's avatar
      CheckIsResolvedNotActiveAnymore: add a last latestVersionTime check · 3a57c1e4
      Simon Latapie authored
      As ApprovalDevScore has been changed to be return a Zero Time if non
      strict (aka if this is a Developer MR) to be consistent with the
      EmojiDevScore, there is a scenario where the check will not be able to
      determine the real "waiting time".
      This may appear if:
      - this is a Developer MR
      - Some other Developer approves the MR really soon (lastSignChange ==
        Zero now)
      3a57c1e4
  3. May 06, 2024
  4. Feb 13, 2023
  5. Feb 10, 2023
    • Simon Latapie's avatar
      graph: add WaitingForReviewerFeedback status · 298003fd
      Simon Latapie authored
      Track the explicit Reviewer set in MRs, and wait for the Reviewer
      feedback (and set the WaitingForReviewerFeedback status).
      If the Reviewer add some feedback in the MR, resume the review process.
      
      Fixes #8
      298003fd
  6. Nov 15, 2022
  7. Sep 16, 2022
  8. Apr 15, 2022
  9. Feb 03, 2022
    • Simon Latapie's avatar
      doc: cosmetic refactor · ce56419f
      Simon Latapie authored
      ce56419f
    • Simon Latapie's avatar
    • Simon Latapie's avatar
      ignore upvotes/approval for the "no review" transition · 01eeb753
      Simon Latapie authored
      Fixes #17.
      
      The goal is to avoid upvotes/approval to extend the "no review"
      deadline. This happened when a developer was approving/upvoting a MR:
      - between 0h to 24h before the "no review" deadline (the MR switches from
        "Reviewable" to "Acceptable" and wait 24h after the vote).
      - after the "no review" deadline (the MR switches from "Accepted" to
        "Acceptable" and wait for 24h to go back to its previous state).
      
      Ignoring the presence of votes if there are only upvotes/approvals for
      the "no review" transition should solve both issues without any
      consequence on the other part of the process:
      - if the upvote occurs between 0-48h after the creation of the MR, then
        the "no review" transition will fail during the 0-72h period (deadline
        not reached). During this period, the MR will considered Acceptable,
        then Accepted 24h after the first upvote. After 72h, the "no review"
        transition will succeed no matter what.
      - if the upvote occurs between 48-72h, the "no review" transition will
        fail, MR will be switched to Acceptable. But after 72h, the "no
        review" transition will succeed no matter what, switching MR to
        Accepted.
      - if the upvote occurs after the "no review" deadline, the "no review"
        transition will succeed no matter what, so the MR will be kept as
        Accepted.
      
      Note: all these statements suppose there is no (resolvable/resolved)
      discussion thread opened and/or closed on the MR at all. If this is the
      case, the "no review" transition will fail in any situation, and the
      process will fallback to the previous workflow behavior.
      01eeb753
    • Simon Latapie's avatar
    • Simon Latapie's avatar
      process: speed up additional versions of unreviewed MRs · 694a1620
      Simon Latapie authored
      Fixes #16.
      
      The new "Inactivity" deadline for Developer+ MRs now takes into account
      both the first version of the MR and the last version of it.
      
      With the default threshold values, the goal is to put developer unreviewed MRs
      in Accepted state after the later of 24h after the last non simple change
      (ie fast-forward rebase) and 72h after the MR creation time (or
      out-of-draft time).
      694a1620
    • Simon Latapie's avatar
      api: add first version time function · 31268929
      Simon Latapie authored
      31268929
  10. Jan 28, 2022
  11. Jan 27, 2022
  12. Jan 26, 2022
    • Simon Latapie's avatar
      mr: add a new dev score method (approval) · ccdbc8d1
      Simon Latapie authored
      MR Developer score can now be computed through two different methods:
      - the old one based on the thumbsup/thumbsdown emojis
      - a new one based on the Developers approvals
      
      The bot tries to determine which method should be used to compute the
      vote: if only one method provides a valid score (with a correct update
      time), it is selected. In any other case, the `preferred-score-method`
      parameter is used.
      ccdbc8d1
  13. Jan 14, 2022
  14. Oct 20, 2021
  15. Oct 03, 2021
  16. Jun 03, 2021
  17. Apr 29, 2021
Loading