The NSURL API has changed since iOS 17 and follows the parsing rules
established in the RFC 3986 which broke the download feature of files
containing special characters.

File names containing special characters are now percent encoded before
creating the NSURL object in order to properly form a valid url.

We don't offer external tracks from files on tvOS

This fixes various attempted UI changes from background threads apparent on tvOS

A proper header is added to the file as well as different sections and
useless self references have been removed.

The image displayed in the navigation controller's header is now
properly scaled according to the given space and avoids applying
a weird aspect ratio.

The pCloud cell now displays an icon as the other cloud services.

The cell's title is also fixed and is now properly matching the cloud
service's name.

The audio and subtitles tracks are now properly selected and the
current track index is properly being handled without having to manage
the track selection on the app side.

The audio and subtitles options now include the disable ones and the
track selection is properly handled based on the table view's indexes.

The audio and subtitles disable features are manually added back to the list
of tracks.

When trying to retrieve the audio tracks number on tvOS, the audio tracks
array was being returned instead of the array count, causing a compilation
error.

Robbie Deane authored 2 weeks ago and Felix Paul Kühne committed 2 weeks ago

Currently Plex login ignores the username and password from the UI
and instead always looks up the Keychain for credentials. This will
fail if no credentials have been stored, or if the stored credentials
are incorrect. This will also result in unexpected behavior if the
user wishes to log in with different credentials on the same server.
This change means the code will attempt to log in with the given
username and password before falling back to credentials stored in the
Keychain.

Closes #1824

All server credential keys are stored as Uppercase since a06bbd8b.
This change allows us to look up the correct keys for Plex credentials
rather than returning nil and erroring out.

Towards #1824

Remove other duplicate code from player view controllers, including duplicate methods in the same file.

The sortModel is properly instantiated in the playlist model instead
of being handled by the collection model.

The EditController now also displays the playlist header
when the collection is being reordered by the user.

The header displays a bigger artwork cover with buttons more accessible
to start the playback regularly and shuffled.

Closes #1868

The brightness and volume gestures are now correctly handled when
enabled.

If the gestures are disabled, swiping down will minimize the player.

Closes #1887

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

Before sending the notification, the lastMedia object is checked to
avoid any nil object being pushed with the notification possibly
leading to a crash issue.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The serverBrowser's class is checked before calling the selector in order
to avoid any possible crash issue from happening.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

Users can now select a different value to perform a backward/forward
seek.

Diogo Simao Marques authored 1 month ago and Felix Paul Kühne committed 1 month ago

The hack using the playbackPosition to perform a seek has been replaced
by the standard calls to the jump backward/forward methods of the playback
service.

We are no longer on Freenode for a while now.

Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The default criteria's localized label is updated to "Custom" to match
its purpose.

Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The indicator is removed because the default criteria is not related to any
ascending or descending order.

The default criteria is only based on the user's interaction.

Diogo Simao Marques authored 2 months ago and Felix Paul Kühne committed 2 months ago

The feature allowing the user to change the order of a playlist's media
is now restricted to only the default sorting criteria.

This avoids any issue related to the loss of a the custom order when a
sorting criteria other than default was selected during the changes.