Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Check whether X11 was disabled or not, for instance when building on
Darwin, and disable the check if it is.

The skip is necessary since the header is including Xlib includes and
the check will fail when they are not provided.

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

This will allow to know whether --without-x was provided or not.

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Linux distribution compiling with X might provide X11 from a different
folder than the system one.

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

On MacOS, the checkheader for vlc_media_library.h fails with:

    In file included from checkheader_vlc_media_library_h.c:3:
    /Users/unidan/Workspace/vlc/extras/package/macosx/../../../include/vlc_media_library.h:151:5: error: unknown type name 'time_t'; did you mean 'size_t'?
        time_t i_last_modification_date;
        ^~~~~~
        size_t
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_size_t.h:31:32: note: 'size_t' declared here
    typedef __darwin_size_t        size_t;
                                   ^
    In file included from checkheader_vlc_media_library_h.c:3:
    /Users/unidan/Workspace/vlc/extras/package/macosx/../../../include/vlc_media_library.h:213:5: error: unknown type name 'time_t'; did you mean 'size_t'?
        time_t i_last_played_date;
        ^~~~~~
        size_t
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_size_t.h:31:32: note: 'size_t' declared here
    typedef __darwin_size_t        size_t;
                                   ^
    In file included from checkheader_vlc_media_library_h.c:3:
    /Users/unidan/Workspace/vlc/extras/package/macosx/../../../include/vlc_media_library.h:257:5: error: unknown type name 'time_t'; did you mean 'size_t'?
        time_t i_creation_date;
        ^~~~~~
        size_t
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_size_t.h:31:32: note: 'size_t' declared here
    typedef __darwin_size_t        size_t;
                                   ^
    In file included from checkheader_vlc_media_library_h.c:3:
    /Users/unidan/Workspace/vlc/extras/package/macosx/../../../include/vlc_media_library.h:258:5: error: unknown type name 'time_t'; did you mean 'size_t'?
        time_t i_last_modification_date;
        ^~~~~~
        size_t
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_size_t.h:31:32: note: 'size_t' declared here
    typedef __darwin_size_t        size_t;
                                   ^
    4 errors generated.
    make[4]: *** [Makefile:6719: checkheader_vlc_media_library_h] Error 1

Alexandre Janniaux authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

On MacOS, the checkheader for vlc_atomic.h fails with:

    In file included from checkheader_vlc_atomic_h.c:3:
    /Users/unidan/Workspace/vlc/extras/package/macosx/../../../include/vlc_atomic.h:113:60: error: unknown type name 'time_t'; did you mean 'size_t'?
    int vlc_atomic_timedwait_daytime(void *addr, unsigned val, time_t deadline);
                                                               ^~~~~~
                                                               size_t
    /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX.sdk/usr/include/sys/_types/_size_t.h:31:32: note: 'size_t' declared here
    typedef __darwin_size_t        size_t;
                                   ^
    1 error generated.
    make[4]: *** [Makefile:6718: checkheader_vlc_atomic_h] Error 1

Pierre Lamot authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

Pimpl idiom is used to avoid integrating template implementation in every
classes that uses models

Pierre Lamot authored 1 year ago and Jean-Baptiste Kempf committed 1 year ago

the indexes provided by the user are relative to the view with the index
the loader loads items with absolute position in the view

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 1 year ago

Co-authored-by: Pierre Lamot <pierre@videolabs.io>

Fatih Uzunoğlu authored 1 year ago and Steve Lhomme committed 1 year ago

Before Qt 6.5, it is necessary to provide the timezone explicitly.

We only need to compute it once.

It will copy less than needed if the output size doesn't fit.

es_format_Copy can copy a lot of things we don't need.

vlc_fourcc_GetChromaBPP() gets the same value as is in fmt->i_bits_per_pixel.

VLC_CODEC_RGB15 will report 15 and will be rounded to 16 as before.

And pass the video_format, not the whole es_format_t when filling it.

It doesn't matter what bit depth is on the input.

If biBitCount is 15, we need 2 bytes per pixel, even for a 1x1 output.

bits_per_coded_sample should be 15 for VLC_CODEC_RGB15 which is what
this function returns.

This is the average usable bits per pixel, not related to individual pixels.

It may not even correspond to the padding we may use with a real picture.