Since a878e9d6.

Also remove duplicate include of <climits>.

Alexandre Janniaux authored 1 year ago and Felix Paul Kühne committed 1 month ago

This commit signal the mostlyclean and other dependant targets that it
should clean the targets generated by cargo.

We use a separate target name and add the dependency to
mostlyclean-local so that we can still extend the known automake target.

We also don't use CLEANFILES so that dependencies files are also removed
when using `make mostlyclean-local-rust` to avoid a corrupted tree where
the dependencies would not be removed but the target files they
reference would not exist anymore.

Alexandre Janniaux authored 1 year ago and Felix Paul Kühne committed 1 month ago

It's easier to setup CLEANFILES to $(NULL) at the top makefile and then
always append to it whenever needed.

Steve Lhomme authored 1 month ago and Felix Paul Kühne committed 1 month ago

Either when the video is in portrait mode or when the subtitles
are shown in the black bars and the video area is in portrait mode,
the text can become very large just because we apply a percentage base on
the output height.

We switch mode when the height becomes bigger than the width
so there's a continuity in the ratio when growing/shrinking the
video in one direction or the other.

The static libraries are used in multiple modules for the android
codebase.

Alexandre Janniaux authored 1 month ago and Steve Lhomme committed 1 month ago

Naming the thread entrypoint vlc_entry is confusing in some of the
stacktraces. In particular, for some reason, Qt's module entrypoint
refers to vlc_entry_license+xxxx (where xxxx is an offset) and it feels
like it's being called from the plugin's entrypoint.


        Thread 14 received signal SIGSEGV, Segmentation fault.
        [Switching to Thread 27108.0x6bf8]
        0x00007ffd41ff499f in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        (gdb) bt
        #0  0x00007ffd41ff499f in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #1  0x00007ffd41ff3d71 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #2  0x00007ffd410d57c5 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #3  0x00007ffd41f7458f in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #4  0x00007ffd4181a9b3 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #5  0x00007ffd414f00a8 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #6  0x00007ffd41a86513 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #7  0x00007ffd41bbf651 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #8  0x00007ffd4193bd97 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #9  0x00007ffd41bbf628 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #10 0x00007ffd410075fa in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #11 0x00007ffd414f3b0e in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #12 0x00007ffd408f65e0 in vlc_entry_license () from \\wsl.localhost\Debian\home\janniaux\vlc\build-win64\win64\modules\.libs\libqt_plugin.dll
        #13 0x00007ffd631f9dae in vlc_entry (p=0x266f8216810) at /home/janniaux/vlc/extras/package/win32/../../../src/win32/thread.c:354
        #14 0x00007ffdf728e634 in msvcrt!_beginthreadex () from C:\WINDOWS\System32\msvcrt.dll
        #15 0x00007ffdf728e70c in msvcrt!_endthreadex () from C:\WINDOWS\System32\msvcrt.dll
        #16 0x00007ffdf773259d in KERNEL32!BaseThreadInitThunk () from C:\WINDOWS\System32\kernel32.dll
        #17 0x00007ffdf906af38 in ntdll!RtlUserThreadStart () from C:\WINDOWS\SYSTEM32\ntdll.dll
        #18 0x0000000000000000 in ?? ()
        Backtrace stopped: previous frame inner to this frame (corrupt stack?)

Khalid Masum authored 1 month ago and Steve Lhomme committed 1 month ago

Backport a patch from Ninja 1.12 that adds python 3.13
support. This is necessary because current version of Ninja
does not work with python 3.13 as pipes module is deprecated.

No need for a ternary operator.

Co-authored-by: Alexandre Janniaux <ajanni@videolabs.io>

Fatih Uzunoğlu authored 2 months ago and Steve Lhomme committed 1 month ago

I do not set `scaledSize` to requested size by default, just to partially
override it when either `width` or `height` is 0. However, this means that we need
to initialize the uninitialized part manually by setting it to non-zero
requested size counterpart as I proposed here.

It is not essential to handle inputs and is not used in this header.

Gabriel Lafond-Thenaille authored 4 months ago and Steve Lhomme committed 1 month ago

 * Replace `vlc_preparser_GenerateThumbnail` and `vlc_picture_Export`
   by `vlc_preparser_GenerateThumbnailToFiles`.

Gabriel Lafond-Thenaille authored 3 months ago and Steve Lhomme committed 1 month ago

 * Fix a crash due to variable on a stack not available when a callback
   try to use it.

Brad Smith authored 2 months ago and Steve Lhomme committed 1 month ago

- thread id
- thread naming
- CPU feature detection

When the protoc version is in the a.b.c format the protobuf version
is in the a.b.c.d format. Some version of pkg-config allow the equality
of the two, but not all.

We can just make sure protobuf is between a.b.c and a.b.(c+1).

Fixes #29066

Fixes #28995

A "gathered" SPU is assembled to send to the decoder, and the decoder then handles
the data from there. But it was never released.

Fixes #28992

The p_new element was never added to the chain.

Fixes #28990

arm-unknown-linux-androideabi is not the correct triplet for android.

vlc_module_name should not be exposed in static cfg for now, since it's
not partially linked into each plugin and thus conflicts with the
libvlc/vlccore's definition.

Just as with autotools it may not test the actual compat version of a function,
but the one provided by the toolchain. That allows validating the tests
with the real thing.

The regions can only use "absolute" coordinates since there is no updater.

There will be no region in the SPU and it will never be updated. We don't
need a SPU at all.

Alexandre Janniaux authored 2 months ago and Felix Paul Kühne committed 2 months ago

The test was added in autoconf buildsystem in the following commit:
967e3744.

Pierre Lamot authored 2 months ago and Felix Paul Kühne committed 2 months ago

fix #29034

Steve Lhomme authored 2 months ago and Felix Paul Kühne committed 2 months ago

It's only needed to render the subpicture. The updater should have priority,
as is done in the "last minute" rendering.

Alexandre Janniaux authored 2 months ago and Felix Paul Kühne committed 2 months ago

-Bsymbolic flag is needed when compiling the module with static ffmpeg
build.

Alexandre Janniaux authored 2 months ago and Felix Paul Kühne committed 2 months ago

aarch64-unknown-linux-android is not the correct triplet for compiling
rust for android, and "-unknown" should be dropped.

The same applies to other targets except armv7, which ends with
androideabi instead of android.

Prince Gupta authored 2 months ago and Steve Lhomme committed 2 months ago

useful for changes following this commit

Prince Gupta authored 2 months ago and Steve Lhomme committed 2 months ago

Have a common class in all menu wrappers that implement
some basic functionality - visibility and memory management

implement tableView_popup function for Network context menu