modules/gui/skins2/x11/x11_display.cpp still includes ../share/icons/32x32/vlc.xpm

Flatpak disallows XPM icons and PNG should suffice in any case

Cf. https://docs.flathub.org/docs/for-app-authors/linter/#non-png-icon-in-hicolor-size-folder

When it's uploaded to the VLC contribs, the folder may hold more than one version in the future.

Rather than hardcode to the root or build-aux.

RECONF will install the config.guess/sub files.

It's using UNPACK_DIR and it's really about updating source files.

So it's coherent throughout all the contribs.

Or at least using AC_CONFIG_AUX_DIR.

It used to be pulled as a SDL dependency.
But SDL was removed in c218cfbc.

Thomas Guillem authored 10 months ago and Steve Lhomme committed 10 months ago

Changing timings of the stream module while playing is an intricate
task, therefore modules don't handle any PTS discontinuity.

The PTS discontinuity is now handled in the core:

 - Drain the current stream in case of discontinuity
 - Check from future Play() calls if the stream is drained
 - Keep blocks in a list while waiting for the drain
 - Flush when the stream is finally drained
 - Play back all blocks that were saved

Thomas Guillem authored 10 months ago and Steve Lhomme committed 10 months ago

No functional changes, this will be needed by next commits.

Thomas Guillem authored 10 months ago and Steve Lhomme committed 10 months ago

It is not used for stream discontinuity but to distinguish if a buffer
had already been played.

Thomas Guillem authored 10 months ago and Steve Lhomme committed 10 months ago

It is set back to false just before aout->play and the variable is not
read in between.

To match the values in configure.ac from 63ffd9e4.

To match the values in configure.ac from 931e9f34.

Its has been broken for almost 3 months https://artifacts.videolan.org/vlc/nightly-snap/
And it will need a heavy bit of work to work again with Qt6.

It's the official URL [1] and maybe it's more stable than cgit (which gives a lot of 502 errors).

[1] https://www.gnu.org/software/gettext/manual/html_node/config_002eguess.html