Fatih Uzunoğlu authored 1 week ago and Steve Lhomme committed 19 hours ago

This seems to be similar to 089271fd, I assume something is wrong
with QSG batch renderer's optimizations.

Khalid Masum authored 4 days ago and Steve Lhomme committed 1 day ago

The case PROJECTION_MODE_RECTANGULAR  is always false.

Thomas Guillem authored 4 days ago and Steve Lhomme committed 1 day ago

Fixes GL assert when using nvdec + gl interop.

Gabriel Lafond-Thenaille authored 4 days ago and Jean-Baptiste Kempf committed 2 days ago

Two callbacks are triggered with the event INPUT_EVENT_SUBITEMS:

 * `input_item_parser_cbs_t::on_subtree_added`, which transfers
   ownership to its listener.

 * `vlc_player_cbs::on_media_subitems_changed`, which sends a
   `const input_item_node_t` to its listeners and then frees the node.

Gabriel Lafond-Thenaille authored 4 days ago and Jean-Baptiste Kempf committed 2 days ago

 * change `vlc_player_cbs::on_media_subitems_changed` callback argument
   type from `input_item_node_t *` to `const input_item_node_t *`.

Thomas Guillem authored 4 days ago and Felix Paul Kühne committed 3 days ago

In the case where an ES did not send an update after being paused
(likely when audio only), the last timer point was still valid causing
the Interpolate function to continue.

Do check for paused before interpolating a point.

Fixes #28353

The issue was only visible when using vlc_player_GetTime() and
libvlc_media_player_get_time() (so, no problem for Qt that is using the
timer API).

François Cartegnie authored 2 weeks ago and Felix Paul Kühne committed 3 days ago

refs #28783

Khalid Masum authored 1 week ago and Steve Lhomme committed 4 days ago

Instead of when mouse is pressed.

Mokhlas Hussein authored 3 weeks ago and Steve Lhomme committed 5 days ago

Check if the drawable implements the new method canStartPictureInPictureAutomaticallyFromInline

Mokhlas Hussein authored 3 weeks ago and Steve Lhomme committed 5 days ago

Controls whether PiP can start automatically when video enters inline mode

This fixes linking with llvm-mingw (or any mingw distribution that
doesn't default to linking in winpthreads).

This wasn't noticed in the upstream VLC CI, as it builds with
extras/packages/win32/build.sh, which passes in -Wl,-l:libpthread.a
in VLC_LDFLAGS (in order to prefer linking winpthreads statically,
rather than dynamically, for libraries that do use winpthreads).

This patch has been sent upstream in
https://github.com/xiph/flac/pull/832.

"This release finally makes the encoder multithreaded! Furthermore, the decoder can now handle chained Ogg FLAC files. As always, a lot of things have been fixed and improved."

The relevant patches have been upstreamed and the microbench tool has been dropped.

Prince Gupta authored 8 months ago and Steve Lhomme committed 1 week ago

fixes related warnings as well

Tristan Matthews authored 1 week ago and Steve Lhomme committed 1 week ago

It seems like a new release tarball was pushed with the same version.

Fatih Uzunoğlu authored 2 weeks ago and Steve Lhomme committed 1 week ago

Since calloc is used, this variable remains false and this
prevents calling `xdg_toplevel_show_window_menu()`.

Fatih Uzunoğlu authored 3 weeks ago and Steve Lhomme committed 1 week ago

Currently the interface only provides "video" and "audio"
playlists. Mixed playlists don't seem to be presented.
This is something that can be handled trivially with drag
and drop case.

Adding to playlist action in context menu is more of a
problem, because in that case there is no specific open
playlist view that we can pick as the target.

I'm not sure what is the best behavior with regard to
the latter situation, but I assume we need to segregate
there too, because if the user can not make use of a
mixed playlist, there is no point creating them or
appending media.

I followed a naive approach, simply used `showPlayAsAudioAction`.
However, it could be possible to:
- If there is a single item, check if it is audio or video, and
  pick the appropriate type playlist.
- If there are multiple items, always pick `PLAYLIST_TYPE_ALL`.
- If there are multiple items, iterate through all items, and
  if all of them are the same, pick the appropriate playlist
  (i.e. video, or audio playlist), if there are different type
  of items, pick `PLAYLIST_TYPE_ALL`.

Fatih Uzunoğlu authored 3 weeks ago and Steve Lhomme committed 1 week ago

Dialogs that carry the state of their initiators
should not be singleton. In this case, this dialog
always needs some sort of media to be functional.

This is already the case with the media info
dialog, for example, current media info dialog
is a singleton but media info dialog of a specific
media is not.

Since this dialog is always tied to some specific
media, I see no point of this being a singleton.
Its title suggests that this dialog is only meant
to be used for adding items to an existing or new
playlist.

Asynchronousity is also a problem when it is a
singleton, what happens if the user wants to add
items before the previous (asynchronous) addition
is not complete yet?

Fatih Uzunoğlu authored 3 weeks ago and Steve Lhomme committed 1 week ago

- `QDialog` already handles this.
- The implementation is not correct here,
  enter key should accept the dialog. It is
  also not clear why a dialog specific `reject()`
  is not called when encountering escape key.