Skip to content
Snippets Groups Projects
  1. May 14, 2025
    • Thomas Guillem's avatar
      aaudio: fix assert after restart · 4ea4bfb2
      Thomas Guillem authored and Steve Lhomme's avatar Steve Lhomme committed
      E  [ee43a9e0/bab] libvlc generic: AAudio stream error or disconnected:: AAUDIO_ERROR_DISCONNECTED
      D  [ee18feb0/bab] libvlc audio output: restart requested (7)
      W  onMoreData() data, stream disconnected
      E  processAudioBuffer(26): EVENT_MORE_DATA requested 8208 bytes but callback returned -1 bytes
      E  ../../modules/audio_output/android/aaudio.c:681: void Play(aout_stream_t *, vlc_frame_t *, vlc_tick_t): assertion "state == AAUDIO_STREAM_STATE_STARTING || state == AAUDIO_STREAM_STATE_STARTED" failed
      4ea4bfb2
    • William Woodruff's avatar
      gnutls: remove manual DH prime bits setting · 3c9e4df1
      William Woodruff authored and Steve Lhomme's avatar Steve Lhomme committed
      
      This sets the DH group to an unnecessarily and
      insecure small size. By removing this function
      call GnuTLS will select an appropriate DH
      group from the priority string which, when
      configured appropriately, will always be
      a 2048-bit or larger group.
      
      Signed-off-by: default avatarWilliam Woodruff <william@trailofbits.com>
      3c9e4df1
  2. May 13, 2025
  3. May 12, 2025
  4. May 11, 2025
  5. May 10, 2025
  6. May 09, 2025
  7. May 08, 2025
  8. May 05, 2025
  9. May 04, 2025
  10. May 02, 2025
    • Fatih Uzunoğlu's avatar
      qt: do not check always false variable in `csdmenu_wayland.c` · e1fe8e6d
      Fatih Uzunoğlu authored and Steve Lhomme's avatar Steve Lhomme committed
      Since calloc is used, this variable remains false and this
      prevents calling `xdg_toplevel_show_window_menu()`.
      e1fe8e6d
    • Fatih Uzunoğlu's avatar
      qt: set transaction pending in `MLPlaylistListModel::create()` · 030af374
      Fatih Uzunoğlu authored and Steve Lhomme's avatar Steve Lhomme committed
      030af374
    • Fatih Uzunoğlu's avatar
      qt: when possible segregate playlists in playlist dialog · 405e1efb
      Fatih Uzunoğlu authored and Steve Lhomme's avatar Steve Lhomme committed
      Currently the interface only provides "video" and "audio"
      playlists. Mixed playlists don't seem to be presented.
      This is something that can be handled trivially with drag
      and drop case.
      
      Adding to playlist action in context menu is more of a
      problem, because in that case there is no specific open
      playlist view that we can pick as the target.
      
      I'm not sure what is the best behavior with regard to
      the latter situation, but I assume we need to segregate
      there too, because if the user can not make use of a
      mixed playlist, there is no point creating them or
      appending media.
      
      I followed a naive approach, simply used `showPlayAsAudioAction`.
      However, it could be possible to:
      - If there is a single item, check if it is audio or video, and
        pick the appropriate type playlist.
      - If there are multiple items, always pick `PLAYLIST_TYPE_ALL`.
      - If there are multiple items, iterate through all items, and
        if all of them are the same, pick the appropriate playlist
        (i.e. video, or audio playlist), if there are different type
        of items, pick `PLAYLIST_TYPE_ALL`.
      405e1efb
    • Fatih Uzunoğlu's avatar
      qt: make `PlaylistsDialog` no longer a singleton · 923aea96
      Fatih Uzunoğlu authored and Steve Lhomme's avatar Steve Lhomme committed
      Dialogs that carry the state of their initiators
      should not be singleton. In this case, this dialog
      always needs some sort of media to be functional.
      
      This is already the case with the media info
      dialog, for example, current media info dialog
      is a singleton but media info dialog of a specific
      media is not.
      
      Since this dialog is always tied to some specific
      media, I see no point of this being a singleton.
      Its title suggests that this dialog is only meant
      to be used for adding items to an existing or new
      playlist.
      
      Asynchronousity is also a problem when it is a
      singleton, what happens if the user wants to add
      items before the previous (asynchronous) addition
      is not complete yet?
      923aea96
    • Fatih Uzunoğlu's avatar
      95d0bc05
    • Fatih Uzunoğlu's avatar
      qt: remove `QVLCDialog::keyPressEvent()` · 6a330a63
      Fatih Uzunoğlu authored and Steve Lhomme's avatar Steve Lhomme committed
      - `QDialog` already handles this.
      - The implementation is not correct here,
        enter key should accept the dialog. It is
        also not clear why a dialog specific `reject()`
        is not called when encountering escape key.
      6a330a63
Loading