Skip to content
Snippets Groups Projects

Album art issue

    • Open Issue created by Martin Finkel @mfkl

    https://forum.videolan.org/viewtopic.php?f=37&t=147561

    To upload designs, you'll need to enable LFS and have an admin enable hashed storage. More information

    Child items 0

    No child items are currently assigned. Use child items to break down this issue into smaller parts.

    Activity

    • Evan Blackstone
      Evan Blackstone @AgentCooper ·
      Contributor

      Is this still ongoing? I wouldn't mind taking a crack at it if you haven't already had a chance to dig into it.

    • Martin Finkel
      Martin Finkel @mfkl ·
      Author Developer

      I haven't, feel free!

    • Evan Blackstone
      Evan Blackstone @AgentCooper ·
      Contributor

      Cool, thanks!

      I've been looking at this, and I'm thinking the issue is simply caused by more obscure music not necessarily having results on Deezer, etc.? The sample track (BFG) shows downloaded art for me at least now, so I'm guessing the user who reported it is no longer having the issue?!

      However, I've added some code to my fork using the StorageItemThumbnail class to essentially pull the image file from the tag in cases where the online lookup fails. See screenshots.

      Does this sound like an okay approach? This appears to be a fringe case, so the existing artwork download mechanism should still be handling almost everything...

      The Doom artwork on the left is what was embedded in the provided sample mp3. (Note: I removed the other id3 tag info so that the lookup would fail for the first one.) The other Doom artwork was downloaded.

      library

      now_playing

      Edited by Evan Blackstone
    • Martin Finkel
      Martin Finkel @mfkl ·
      Author Developer

      Sure sounds good, make an MR whenever you're ready.

    • Evan Blackstone mentioned in merge request !7

      mentioned in merge request !7

    • Evan Blackstone
      Evan Blackstone @AgentCooper ·
      Contributor

      Added a WIP MR. Thanks,

    Please register or sign in to reply

    VideoLAN code repository instance