Cannot play shared file with '@' in the name, VLC repeatedly asking for SMB credentials

Description

SMB share provided by OMV5 (my normal video share requires credentials, but same thing happens on a public share). VLC's preference for SMBv1 disabled. Trying to play a file named "720p_Around_the_World-@60fps.mp4" results in VLC repeatedly asking for SMB credentials. Renaming the file fixes the problem. Likewise, adding "@" into the name of currently working files triggers the issue on them.

Expected behavior

Valid characters in file path should not cause issues with playback/accessing the file.

Actual behavior

Files with "@" in the name cannot be played from SMB share.

Steps to reproduce

1. Prepare an SMB shared folder with some compatible video, make 2 copies - with and without "@" in the name
2. Navigate to the share within VLC
3. Try playing each copy

Screenshot / video

Screenshot_20210211-171751

Context

App version

3.3.4

Android version

10

Device model

YT-X705L (Lenovo Yoga Smart Tab 10, LTE data only)

App mode

Auto

changed the description

marked this issue as related to vlc#17859 (closed)

marked this issue as related to #1777

changed milestone to %3.4.x

added bug label

I can reproduce. I am not sure it's related to these two other issues. I think there should be a char escape needed somewhere to avoid considering the @ char as a delimiter or the url.

2021-03-23 13:08:49.125 15189-6406/? D/VLC: [0000007c35b9d160/1906] libvlc input: Creating an input for preparsing 'test@credentials'
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007c35b9d160/1907] libvlc input: using timeshift granularity of 50 MiB
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007c35b9d160/1907] libvlc input: using default timeshift path
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007c35b9d160/1907] libvlc input: `smb://AZABUNTU/Anonymous/test%40credentials' gives access `smb' demux `any' path `AZABUNTU/Anonymous/test%40credentials'
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007bc5bf33a0/1907] libvlc demux: looking for access_demux module matching "smb": 7 candidates
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007bc5bf33a0/1907] libvlc demux: no access_demux modules matched
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007bd5c4d0a0/1907] libvlc stream: creating access: smb://AZABUNTU/Anonymous/test%40credentials
2021-03-23 13:08:49.127 15189-6407/? D/VLC: [0000007bd5c4d0a0/1907] libvlc stream: looking for access module matching "smb": 25 candidates
2021-03-23 13:08:49.128 15189-6407/? W/VLC: [0000007bd5c4d0a0/1907] libvlc stream: SMB 2/3 disabled by the user, using *unsafe* SMB 1
2021-03-23 13:08:49.148 15189-6407/? D/VLC: [0000007bd5c4d0a0/1907] libvlc stream: Session: Host name = AZABUNTU, ip = 192.168.1.172
2021-03-23 13:08:49.158 15189-15189/? E/RecyclerView: No adapter attached; skipping layout
2021-03-23 13:08:49.160 15189-6407/? E/VLC: [0000007bd5c4d0a0/1907] libvlc stream: Unable to connect/negotiate SMB session
2021-03-23 13:08:49.166 15189-15189/? E/RecyclerView: No adapter attached; skipping layout
2021-03-23 13:08:49.175 15189-6407/? E/VLC: [0000007bd5c4d0a0/1907] libvlc stream: smb2_parse_url failed
2021-03-23 13:08:49.175 15189-6407/? D/VLC: [0000007bb5b96b20/1907] libvlc keystore: looking for keystore module matching "file_crypt,none": 3 candidates
2021-03-23 13:08:49.175 15189-6407/? D/VLC: [0000007bb5b96b20/1907] libvlc keystore: using keystore module "file"

added libVLC label

mentioned in issue #2043 (closed)

assigned to @tguillem

Solved by vlc!356 (merged).

Needs to have libVLC updated.

Let's close it then as libvlc will be updated before the next beta.

Merged

assigned to @Aza and unassigned @tguillem

closed