Option to change Playback Speed not displayed for streaming media
Description
This behavior was introduced in !166 (merged) and related to ticket #914 (closed). The original poster does not specify what was meant by 'it does nothing', but I have confirmed that setting a playback speed is supported with streaming media in VLC on Windows, OS X, and iOS, with the change in playback speed clearly evident.
The linked merge requests introduces a check for ability to seek a file in order to suppress the playback speed button. Tracking or seeking may not make sense with streaming media since you can't force a streaming server to serve you more slowly or quickly, but modifying media playback speed does make sense-- the buffer of streamed bytes can be played at any arbitrary speed, with the result of either stuttering when the application waits for the next buffer to be filled, or skips when the buffer is exhausted, but the server has already served up the next bytes. I believe the expected results of the original issue should have been that this behavior was exhibited, rather than taking "does nothing" as expected behavior.
For background context, this came up in a situation where a streaming server was delivering media at about 92% of playback speed, resulting in continuous pausing. No frames were being dropped, so the suggestion was made to set playback speed to the nearest value .92, to improve perceived performance. Not a very common scenario, but given the number of other OS builds that were capable of dealing with it leads me to suggest that the Android builds should aim for parity.
Expected behavior
Playback option displayed in the three-dots menu Setting a playback speed results in the buffer of streamed data being played at that speed
Actual behavior
Playback option suppressed for streaming media
Steps to reproduce
- Open a video stream
- Tap 3 dots menu
- Tap Playback Speed
Screenshot / video
Context
App version
3.12.2
Android version
9 (tv) 10 (phone)
Device model
Sony Bravia (tv) Galaxy S10e (phone)
App mode
Smartphone
TV
Auto