Allow the library users not to provide an implementation for the cacher.

Queueing a task can fail. The next commits will introduce queue failure
when no cache implementation is provided.

This caused the the addRoot to fail because of the missing trailing '/',
the folder would not match any mountpoint, and isn't added in db,
failing any attempt at discovery / reload.

10 artists was creating DB files way to bigs for the test case (near
500Kb). We don't need that much dummy data to validate the migrations.

Those values are only used in debug assertions.

Work around a GCC `-Wignored-attributes` warning that was triggered due
to `fclose` being tagged as `__nonnull((1))`.

We should not succeed if `fclose` fails for the target file.

The RAII wrapper here does not improve readability or shorten the code.
Removing it works around a GCC `-Wignored-attributes` warning that was
triggered due to `fclose` being tagged as `__nonnull((1))`.

It should not be assumed that the playlist was saved properly when
`fclose` fails.

The RAII wrapper here does not improve readability or shorten the code.
Removing it also works around a GCC `-Wignored-attributes` warning that
was triggered due to `fclose` being tagged as `__nonnull((1))`.

Duncan McNamara authored 1 year ago and Alaric Senat committed 1 year ago

Co-Authored-by: Alaric Senat <dev.asenat@posteo.net>

Duncan McNamara authored 1 year ago and Alaric Senat committed 1 year ago

Co-Authored-by: Alaric Senat <dev.asenat@posteo.net>

Duncan McNamara authored 1 year ago and Alaric Senat committed 1 year ago

Co-Authored-by: Alaric Senat <dev.asenat@posteo.net>

Duncan McNamara authored 1 year ago and Alaric Senat committed 1 year ago

Co-Authored-by: Alaric Senat <dev.asenat@posteo.net>

Duncan McNamara authored 1 year ago and Alaric Senat committed 1 year ago

Co-Authored-by: Alaric Senat <dev.asenat@posteo.net>

Duncan McNamara authored 1 year ago and Alaric Senat committed 1 year ago

Co-Authored-by: Alaric Senat <dev.asenat@posteo.net>